Cancer_modules_depression_epilepsy convert excel files to csv files #1487
Conversation
|
Hi @tbhallett. You may want to do a final review on this PR and merge when happy. I have already tested hashing DataFrames from both master and this branch. They are all outputting same hash Thanks |
| @@ -0,0 +1,3 @@ | |||
| version https://git-lfs.github.com/spec/v1 | |||
| oid sha256:23f3b4cef6927114b414344c95a4c262691312049ce7dc101042230e895ff066 | |||
There was a problem hiding this comment.
do we need to keep this file?
There was a problem hiding this comment.
@andrew-phillips-1 , should I delete this file?
| @@ -0,0 +1,3 @@ | |||
| version https://git-lfs.github.com/spec/v1 | |||
| oid sha256:e5f0e3c22d3b82061dc884df42f3a304dd0cd1b205166d1e5460c8569eba0d53 | |||
There was a problem hiding this comment.
similarly if this is just documentation r.e. assumptions maybe it doesnt need to live on master?
There was a problem hiding this comment.
should I delete it then? I will defer to you or @andrew-phillips-1 for a final decision
There was a problem hiding this comment.
Hi @mnjowe It's fine to delete from here so long as we have a central copy kept somewhere. I can't recall where the write-ups are held.
There was a problem hiding this comment.
great, thanks @andrew-phillips-1. For all the files I have converted, original copies are stored in our TLO sharepoint here
# Conflicts: # resources/epilepsy/ResourceFile_Epilepsy.xlsx
…ew_modules' into mnjowe/convert_excel_to_csv_andrew_modules
|
Some files here have also been changed in #1487. Is this PR based off that one? |
|
Hi Asif @tamuri. That link points to this same PR BUT I agree there might be that possibility of one excel file re-converted in another PR. The reason being I have had more PR's on converting excel files to CSV branching off master. |
This PR aims at converting excel files in all cancer modules plus epilepsy and depression modules
Person responsible - Andrew Phillips