Add test for randomized n_step

Also fix example code
UCL · Dec 5, 2024 · 6d58bc6 · 6d58bc6
1 parent 8f3913f
commit 6d58bc6
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 4 deletions.
diff --git a/R/hamiltonian.R b/R/hamiltonian.R
@@ -102,7 +102,7 @@ log_density_ratio_hamiltonian <- function(
 #'
 #' # Proposal with number of steps randomly sampled uniformly from 5:10
 #' sample_uniform_int <- function(lower, upper) {
-#'   lower + sample.int(upper - lower + 1) - 1
+#'   lower + sample.int(upper - lower + 1, 1) - 1
 #' }
 #' proposal <- hamiltonian_proposal(
 #'   target_distribution,

diff --git a/man/hamiltonian_proposal.Rd b/man/hamiltonian_proposal.Rd
diff --git a/tests/testthat/test-hamiltonian.R b/tests/testthat/test-hamiltonian.R
@@ -1,10 +1,12 @@
-hamiltonian_proposal_with_standard_normal_target <- function(n_step) {
+hamiltonian_proposal_with_standard_normal_target <- function(
+    n_step, sample_n_step = NULL) {
   function(scale = NULL, shape = NULL) {
     hamiltonian_proposal(
       target_distribution = standard_normal_target_distribution(),
       n_step = n_step,
       scale = scale,
-      shape = shape
+      shape = shape,
+      sample_n_step = sample_n_step
     )
   }
 }
@@ -49,3 +51,13 @@ for (dimension in c(1L, 2L, 3L)) {
     }
   }
 }
+
+test_scale_and_shape_proposal(
+  hamiltonian_proposal_with_standard_normal_target(
+    n_step = c(1, 5),
+    sample_n_step = function(n) n[1] + sample.int(n[2] - n[1] + 1, 1) - 1
+  ),
+  proposal_name = sprintf("Hamiltonian proposal with randomized n_step"),
+  dimensions = c(1L, 2L),
+  scales = c(0.5, 1., 2.)
+)