Use more efficient matrix vector multiplication op in proposals #59
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#47 switched to always using dense matrix constructed with
diag
for diagonal shapes, which incurs a quadratic cost matrix vector multiplication operation, even though it should be possible in linear, but this was found to much quicker in profiling than usingMatrix::diagonal
. This PR instead defines a custom matrix-vector multiplication operator%@%
to use in proposals that treats vector shapes as diagonal matrices and scalar shapes as scaled identities, and performs the matrix vector multiply in linear cost.