Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update adapter defaults #62

Merged
merged 5 commits into from
Dec 10, 2024
Merged

Update adapter defaults #62

merged 5 commits into from
Dec 10, 2024

Conversation

matt-graham
Copy link
Collaborator

  • Changes default behaviour of sample_chain function to be to use dual averaging scale adapter and dense covariance shape adapter.
  • Adds two new functions scale_adapter and shape_adapter which wrap the algorithm specific variants.
  • Changes variance and covariance shape adapters to defaulting to using kappa = 1 corresponding to empirical (co)variance updates.

Copy link

codecov bot commented Dec 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (4996fa3) to head (83abf52).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #62   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          521       533   +12     
=========================================
+ Hits           521       533   +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@matt-graham matt-graham merged commit 6d08089 into main Dec 10, 2024
11 checks passed
@matt-graham matt-graham deleted the mmg/update-adapter-defaults branch December 10, 2024 16:27
@matt-graham matt-graham added the enhancement New feature or request label Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant