Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added current company for alumni information #121

Open
wants to merge 3 commits into
base: sunshine-v1
Choose a base branch
from

Conversation

arjunmanoj333
Copy link

Alumni with an associated Company tag in Contentful will have their current company appear on their profile

@arjunmanoj333 arjunmanoj333 self-assigned this Apr 19, 2023
darren2hang
darren2hang previously approved these changes Apr 25, 2023
Copy link

@darren2hang darren2hang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for working on this!

Edit: after merging there is a bug on how the TeamCard looks when the company name is too long

@darren2hang
Copy link

I noticed in the figma that the italicized company font is size 14 and the rest of the font is 16.
In the css file, we're using 1.1rem for the size of the text in the team card.
Let's make the italicized "Now: Company name" font-size 1rem.

Copy link

@darren2hang darren2hang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit on the font size of the company name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants