Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ticket # 147 - About us page layout #166

Open
wants to merge 1 commit into
base: new_site_dev
Choose a base branch
from

Conversation

lakshman8664
Copy link

finished page structure using existing components.
About, Board Member Highlights, and Alumni Recollections sections filled with static data
Filled Upcoming Events and Past Events (dynamic data) with dummy values temporarily

Copy link

@accesslint accesslint bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are accessibility issues in these changes.

<div className="flex flex-col items-center mb-8">
{image && (
<div className="w-32 h-32 overflow-hidden rounded-full mb-4">
<img
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This image is missing a text alternative. This is a problem for people using screen readers.

@lakshman8664 lakshman8664 force-pushed the about_us_layout branch 2 times, most recently from dce0ee2 to 008cbee Compare November 6, 2024 22:47
Copy link
Member

@olliepai olliepai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls make the images on the GenericCard be the same height as the text (see Figma).

Note: The home page also uses the GenericCard component so make sure any styling changes do not break the home page.

Everything else looks good!

@lakshman8664
Copy link
Author

image

Modified the image size in "upcoming events" section. Created a new card for this instead of modifying the GenericCard component.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants