-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ticket # 147 - About us page layout #166
base: new_site_dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are accessibility issues in these changes.
<div className="flex flex-col items-center mb-8"> | ||
{image && ( | ||
<div className="w-32 h-32 overflow-hidden rounded-full mb-4"> | ||
<img |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image is missing a text alternative. This is a problem for people using screen readers.
dce0ee2
to
008cbee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pls make the images on the GenericCard be the same height as the text (see Figma).
Note: The home page also uses the GenericCard component so make sure any styling changes do not break the home page.
Everything else looks good!
008cbee
to
f6a5ef8
Compare
f6a5ef8
to
1421ed0
Compare
finished page structure using existing components.
About, Board Member Highlights, and Alumni Recollections sections filled with static data
Filled Upcoming Events and Past Events (dynamic data) with dummy values temporarily