Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Qr-code display for safebag and backdrop around existing ones #117

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

AnoldGH
Copy link
Contributor

@AnoldGH AnoldGH commented Jul 22, 2024

  • Adds qr-code display for safebag
  • Wraps qr-code displays for certificate and trust anchors so that it's more friendly to users in general
  • [Next step] Adds qr-reader for certificate and safebag

@zjkmxy
Copy link
Collaborator

zjkmxy commented Jul 23, 2024

Unfortunately adding QR code for safebags on the website does not help. The safebag is obtained somewhere and then inputed to workspace for bootstrap. So the most important part is that the somewhere should support QR cde display.

@AnoldGH
Copy link
Contributor Author

AnoldGH commented Jul 23, 2024

Unfortunately adding QR code for safebags on the website does not help. The safebag is obtained somewhere and then inputed to workspace for bootstrap. So the most important part is that the somewhere should support QR cde display.

I see. That makes very sense.

This update also wrapped backdrop components around existing QR displays, so they are shown only when the button is pressed and in full-screen. This I think makes using QR codes much more friendly for mobile users. Let me know if I should create a separate PR for it.

@zjkmxy
Copy link
Collaborator

zjkmxy commented Jul 23, 2024

Let me know if I should create a separate PR for it.

If that is the case, let me review it and get it merged. No need for separate PR.

Copy link
Collaborator

@zjkmxy zjkmxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zjkmxy zjkmxy merged commit 011dd6e into UCLA-IRL:main Jul 23, 2024
2 checks passed
@AnoldGH AnoldGH deleted the qr-code branch July 23, 2024 06:02
@zjkmxy zjkmxy linked an issue Jul 23, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allowing multiple ways to create or join workspaces
2 participants