Skip to content
This repository was archived by the owner on Jul 29, 2025. It is now read-only.

Added qr-reader for safebag wrapped with backdrop #118

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

AnoldGH
Copy link
Contributor

@AnoldGH AnoldGH commented Jul 23, 2024

Currently only trust anchor field implements QR-reader. The video (from camera) is relatively posited and looks awkward especially for mobile users.

This update adds QR reader to safebag field (not containing passphrase) and wrapped existing QR-reader with Backdrop components, so that the video is displayed separately from other components and in full-screen.

@tianyuan129 tianyuan129 requested a review from zjkmxy July 24, 2024 15:59
Copy link
Collaborator

@zjkmxy zjkmxy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't have time to try it on a phone but I assume it would work.
If it turns out not, we fix then.

@zjkmxy zjkmxy merged commit c3a7306 into UCLA-IRL:main Jul 25, 2024
2 checks passed
@AnoldGH AnoldGH deleted the qr-reader branch February 21, 2025 02:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants