Fix some PDF related issues #133
Conversation
Currently pdfslick has problem with interface. ifame pdf works well but it depends on browser and can't work on mobile For now just use iframe way
fix `./build-meta.bash: 7: [[: not found` fix build-meta.ts generate syntax problem
Currently, when you navigate to another view and click on a path, it doesn't automatically redirect to the editor view, which is not the intended behavior
I hope this does not break things. I'm not able to test it on my phone or iPad before the code is released. |
I think it won't be a big problem. |
It also works fine on iPad as an installed PWA. I think it's good. |
|
Great, I think after it being released and tested, we can remove all PDFSlick related dependency. I can make another PR to do this. |
I have already done. But thanks. |
f0d4650 Fixed the
./build-meta.bash: 7: [[: not founderror occurring in bothpnpm devandbuildprocesses.623e35c Resolved an issue where navigating to another view (PDF, both, log) and clicking on a path did not automatically redirect to the editor view, which was unintended behavior.
fa7ade7 Fixed issues with PDF display and the functionality of the both view. Most modern desktop browsers support using iframes to display PDF files, which is not supported by mobile browsers. However this is still a big improvement over the previous not usable state (Before the pdf view will freeze the whole page except the nav bar and not work on both view). The pdfslick dependency was retained and can be removed in the future.