Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for optimise chopping boundaries #12

Merged
merged 10 commits into from
Oct 17, 2022
Merged

Add tests for optimise chopping boundaries #12

merged 10 commits into from
Oct 17, 2022

Conversation

sillitoe
Copy link
Contributor

Details:

  • refactor to handle problems with exceptions rather than "NaN"
  • refactor to use Segment and Chopping objects (rather than str)
  • add tests

@sillitoe sillitoe requested a review from rauerc October 12, 2022 14:50
@sillitoe sillitoe merged commit 29115ba into main Oct 17, 2022
@sillitoe sillitoe deleted the add-tests-for-optimise-chopping-boundaries branch October 17, 2022 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rauerc rauerc Awaiting requested review from rauerc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@sillitoe