Compare md5 crhs #54
Merged
Compare md5 crhs #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as file is already open in click
Make description null, so FASTA header is filename
Replace file_stub with af_domain_id_str Replace click.echo with LOG.debug to tidy output Replace LOG.info with LOG.debug
Add flag for gzipped chains Add option for status_log Implement StatusLog writer Fix issue with boundaries as str Add open function to deal with regular or gzip files Add function write_status_log
Add click flag for gzipped cifs
sillitoe
reviewed
Mar 10, 2023
| @@ -235,6 +266,7 @@ def calculate_domain_id_post_tailchop( | |||
| af_domain_id: AFDomainID, | |||
| af_chain_mmcif_dir: Path, | |||
| cutoff_plddt_score: int, | |||
| gzipped_af_chains = bool, | |||
There was a problem hiding this comment.
no, this needs to be:
gzipped_af_chains: bool
or if you want to give it a default value, it should be
gzipped_af_chains: bool = True
There was a problem hiding this comment.
adding the default value would match the existing functionality, but allow a different option - which is generally what you want to do
There was a problem hiding this comment.
(note: this is currently working because the function bool evaluates to true)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.