-
Notifications
You must be signed in to change notification settings - Fork 3
Pull Request Process
Divyank Shah edited this page Aug 20, 2022
·
1 revision
Make sure that your pull request has the following components:
- Assigned yourself the pull request under the
Assignees
section - Assigned the corresponding issue under the
Development
section - Appropriate labels if applicable (ie
DO NOT MERGE
if still working) - Make sure that you have a appropriate title for your pull request
- Ensure there are no merge conflicts with any files, if so, please resolve them and ask someone if unable to resolve
- Ensure it passes any CI/CD checks if in place
- Update your branch with the
dev
branch if you have not done so already
To merge a pull request the following rules have been applied:
- No merge conflicts must exist
- All conversations must be resolved (any requested changes must be resolved)
- CI/CD checks must pass if implemented
- Minimum of 2 reviews must review your code before allowing you to merge