Skip to content

Pull Request Process

Divyank Shah edited this page Aug 20, 2022 · 1 revision

Make sure that your pull request has the following components:

  1. Assigned yourself the pull request under the Assignees section
  2. Assigned the corresponding issue under the Development section
  3. Appropriate labels if applicable (ie DO NOT MERGE if still working)
  4. Make sure that you have a appropriate title for your pull request
  5. Ensure there are no merge conflicts with any files, if so, please resolve them and ask someone if unable to resolve
  6. Ensure it passes any CI/CD checks if in place
  7. Update your branch with the dev branch if you have not done so already

To merge a pull request the following rules have been applied:

  1. No merge conflicts must exist
  2. All conversations must be resolved (any requested changes must be resolved)
  3. CI/CD checks must pass if implemented
  4. Minimum of 2 reviews must review your code before allowing you to merge
Clone this wiki locally