Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OHRI-2053 CaCx - update metadata to use config instead of constants #1736

Merged
merged 6 commits into from
Jan 11, 2024
Merged

OHRI-2053 CaCx - update metadata to use config instead of constants #1736

merged 6 commits into from
Jan 11, 2024

Conversation

arodidev
Copy link
Contributor

@arodidev arodidev commented Jan 9, 2024

Requirements

  • This PR has a title that briefly describes the work done including the ticket number. If there is a ticket, make sure your PR title includes the ticket number in the format OHRI-123 My PR title.
  • My work includes tests or is validated by existing tests.

Summary

Refactor esm-cervical-cancer-app to use values from config instead of constants

Screenshots

Related Issue

Other

@arodidev arodidev marked this pull request as ready for review January 10, 2024 05:41
ODORA0
ODORA0 requested changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@ODORA0 ODORA0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arodidev Let us also add configuration for the form names, just add a new node formNames and do the same for all references of the forms in the components. See example here

@ODORA0 ODORA0 requested a review from pirupius January 11, 2024 07:19
pirupius
pirupius suggested changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@pirupius pirupius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some final tweaks before we can get this in

@pirupius pirupius requested a review from ODORA0 January 11, 2024 07:33
@ODORA0 ODORA0 merged commit 7d3798a into UCSF-IGHS:dev Jan 11, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pirupius pirupius pirupius approved these changes

@ODORA0 ODORA0 ODORA0 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@arodidev @pirupius @ODORA0