Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance/deprecation futurewarn updates #27

Merged
merged 12 commits into from
Apr 6, 2021

Conversation

sablanchard
Copy link
Contributor

@sablanchard sablanchard commented Apr 1, 2021

@coveralls
Copy link

coveralls commented Apr 1, 2021

Coverage Status

Coverage increased (+3.1%) to 92.604% when pulling eaad726 on maintenance/depreciation-futurewarn-updates into dce59a3 on dev.

Copy link
Member

@smmaurer smmaurer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good to me.

Bumping the GeoPandas requirement to v0.9+ means ending support for Python 3.5, which we should note in setup.py (drop line 20, change line 28 to 3.6).

The Travis tests are failing in Python 3.5 (of course), but also 3.7 because of a Travis glitch. My recollection of what's happening is that their py37 image includes a copy of NumPy already installed, but it's a little old and ends up being incompatible with the copy of Pandas that's installed from PyPI. We've seen this in other repos too.

https://travis-ci.org/github/UDST/osmnet/builds/765409781

It's been a couple of months without a fix on their end, so my inclination is to drop Python 3.7 from our test script (along with 3.5).

https://github.com/UDST/osmnet/blob/dev/.travis.yml#L6

@sablanchard
Copy link
Contributor Author

sablanchard commented Apr 1, 2021

Agreed, dropped tests in 3.7 for now. Decided to set geopandas >= 0.8.2 to preserve compatibility with Python 3.5

@smmaurer smmaurer changed the title Maintenance/depreciation futurewarn updates Maintenance/deprecation futurewarn updates Apr 6, 2021
@smmaurer smmaurer merged commit 0c5af00 into dev Apr 6, 2021
@smmaurer smmaurer deleted the maintenance/depreciation-futurewarn-updates branch April 6, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants