Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Larger Travis build matrix #49

Merged
merged 8 commits into from
Jan 29, 2019
Merged

Larger Travis build matrix #49

merged 8 commits into from
Jan 29, 2019

Conversation

smmaurer
Copy link
Member

@smmaurer smmaurer commented Nov 2, 2018

This PR expands the Travis build matrix:

  1. Python 2.7 + Pandana 0.3
  2. Python 2.7 + Pandana 0.4
  3. Python 3.6 + Pandana 0.3
  4. Python 3.6 + Pandana 0.4

Combination 4 fails because Travis hangs in the demo notebook. We haven't been able to diagnose this or reproduce it outside of Travis.

Combination 3 fails at a later point, because of a temporary incompatibility between the latest versions of matplotlib and basemap.

These two builds are "allowed" to fail, so that the overall job passes.

We can merge this if it seems helpful, or drop it!

@smmaurer
Copy link
Member Author

Updates:

  1. Matplotlib 3.0.2 fixes one of the problems that was causing Python 3 Travis builds to fail -- combination 3 in the original comment now works.

  2. Combination 4 still causes Travis to hang, but works everywhere else.

I've edited the Travis script to allow only combination 4 to fail, and also to express the version constraints differently now that there's an 0.4.1 release of Pandana.

@sablanchard sablanchard self-requested a review January 29, 2019 23:52
Copy link
Contributor

@sablanchard sablanchard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@sablanchard sablanchard merged commit 9ffa00d into dev Jan 29, 2019
@sablanchard sablanchard deleted the travis-hotfix branch January 30, 2019 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants