ObjectDumper: Replaced usage of the old 'GetEnumNames' #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
API with the newer 'ForEachName' API when dumping the UEnum names array.
|
Thank you! |
localcc
pushed a commit
that referenced
this pull request
Sep 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the Lua error
UEnum::GetEnumNames/GetNames is not safe for <4.15 because the names array type changed and we haven't abstracted that yet.This means the object dumper now works in UE 4.13.
Note that this patch causes addresses for each value in the names array to not be dumped.
The addresses are not very important for names.
To bring the addresses back, the
ForEachNameAPI would need to pass it because it's dependent on the UE version.The
Keyparameter could perhaps be passed as a pointer instead of a value since that would always be at the start of the element.