Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implementation of popup cards #132

Merged
merged 14 commits into from
Dec 27, 2021
Merged

Conversation

schumijo
Copy link
Collaborator

@schumijo schumijo commented Dec 22, 2021

Light and power outlet responsive popups with documentation

Still to-do :

  • Language translation
  • Hide color_temp when not supported

We are close to release the first beta version 👍

Long term to-do :

  • Rework air conditionner popup to be responsive
  • Add more card compatibility

@schumijo
Copy link
Collaborator Author

schumijo commented Dec 22, 2021

I will work on format check later....

@schumijo
Copy link
Collaborator Author

Hi @CM000n,

Can I solve "string value is not quoted with double quotes" error with pre-commit automatically ?
Or do I need to edit manually the file ?

@CM000n
Copy link
Collaborator

CM000n commented Dec 23, 2021

Hi @schumijo , unfortunately these cannot be fixed automatically at the moment. :-(
If I find time later, I can take care of it and send you a PR.

@CM000n
Copy link
Collaborator

CM000n commented Dec 23, 2021

Hi @schumijo, I made a commit that fixed the remainig pre-commit issues.

@schumijo
Copy link
Collaborator Author

Hi @CM000n,

Thank you !
I don't know when you plan to release the next beta, but you can merge this PR to include popup for light and power outlet

@CM000n
Copy link
Collaborator

CM000n commented Dec 24, 2021

Ahh, sorry. I just released a new version this morning as a Christmas present ;-)
I think I won't be so active over the next days, but of course you can always release a version if it makes sense from your point of view :-)

@schumijo
Copy link
Collaborator Author

Ok I will do it on next week.

@CM000n
Copy link
Collaborator

CM000n commented Dec 24, 2021

Cool! If you haven't seen it yet, our release drafter automatically creates a draft here for every merge that goes into the "dev" branch:
https://github.com/UI-Lovelace-Minimalist/UI/releases
If you like, you can just adapt it a little and use it for a release.
But I think I'll drop by from time to time. Just not as regularly as the last few days

@bavo
Copy link
Collaborator

bavo commented Dec 26, 2021

Oh shit, since you closed the previous pull request I didn't get updates from this pull request.
@schumijo great works so far 💪
I've integrated the changes into my configuration and everything works smoothly 👍

@schumijo schumijo merged commit e855db4 into UI-Lovelace-Minimalist:dev Dec 27, 2021
@schumijo schumijo deleted the popups-dev branch December 29, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants