-
Notifications
You must be signed in to change notification settings - Fork 277
fix(ui5-menu): adapt mobile menu to latest visual design #12879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
🚀 Deployed on https://pr-12879--ui5-webcomponents-preview.netlify.app |
|
Hey @UI5/ui5-team-ctr-rod, I made some minor changes to the NavigationMenu if you could please take a look? The NavigationMenu looks quite a bit different from our menu and I couldn't find the close button to adapt it as well. Thanks, |
Hello @didip1000, the NavigationMenu doesn't appear on mobile devices, so you can keep it unchanged. |
|
Hey @TeodorTaushanov, In that case should I remove the entire "if is phone" conditional in the menu and menu item? I cant leave it unchanged because I'm removing getters and message bundle texts that are currently being used in that menu. |
|
@didip1000, you can indeed remove "if is phone". Please make any necessary adjustments as needed. |
The close button in the
ui5-menuon mobile devices has been changed from a "x" in the header to a "Cancel" button in the footer.