feat(ui5-input): Add highlighting #1943
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladitasev
reviewed
Jul 13, 2020
| {{/if}} | ||
| {{#if description}} | ||
| <span part="description" class="ui5-li-desc">{{description}}</span> | ||
| <span part="description" class="ui5-li-desc">{{{description}}}</span> |
There was a problem hiding this comment.
Let's discuss this in a wider round. If we use {{{ for the representation of a property that can be set programatically in a so common component, this could be a security risk. We could strip script tags from the description to counter the problem too.
The same goes for the other 2 places with {{{
packages/main/src/Input.js
Outdated
| }, | ||
|
|
||
| /** | ||
| * Defines if characters within the suggestions to be highlighted |
|
|
||
| /** | ||
| * Defines if characters within the suggestions to be highlighted | ||
| * in case the input value matches parts of the suggestions text. |
There was a problem hiding this comment.
Maybe also add a comment that it only works with suggestions enabled.
packages/main/src/Input.js
Outdated
| const Suggestions = getFeature("InputSuggestions"); | ||
| if (Suggestions) { | ||
| this.Suggestions = new Suggestions(this, "suggestionItems"); | ||
| this.Suggestions = new Suggestions(this, "suggestionItems", true); |
There was a problem hiding this comment.
Shouldn't this be this.hightlight instead of true?
vladitasev
approved these changes
Jul 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add highlighting support for the suggestion text and suggestion description,
that can be enabled with the newly added "highlight" property of the Input.
FIXES: #1918
Technical details:
<b>tags around the characters that have to be highlighted and triple "{{{" moustache statements so these<b>are interpreted properly.