fix(ui5-menu): fix sub-menu closing if the first item is disabled #6941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hinzzx
changed the title
hinzzx
changed the title
tsanislavgatev
requested changes
Apr 20, 2023
Contributor
tsanislavgatev
left a comment
tsanislavgatev
left a comment
There was a problem hiding this comment.
Removing the pointer events gives the disabled items options to be clicked and the text to be marked. This interactions are not wanted in disabled items.
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a
ui5-menu-itemis marked asdisabled, and it is the first item within asub-menu, thesub-menuis automatically closed. This is because when the mouse pointer moves over thesub-menu, it cannot interact with the first disabled item, which triggers thesub-menuto close.Before
After
Fixes: #6925 , #6709