Changing Uize Overrides #55
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… loaded, preventing the need to special case the loading of Uize.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Presently, Uize static functions can be overridden. moduleUrlResolver, in particular, is specifically designed to be overridden. This means Uize.js must be loaded, then moduleUrlResolver must be changed, and then the rest of the modules would need to be loaded. This would require special-casing the Uize.js inclusion, which we currently load as part of our concatenated js payload.
This changes Uize so you can specify overrides before Uize.js is loaded, that way any existing override code can be moved before the Uize.js load without requiring changes.
We have tested this change for a week on QA and didn't notice any issues, and now it is live on www.zazzle.com .
Let me know if anything is fishy about this code, or if you think it should be done in a different way.
Thanks!
Quentin Brooks