Skip to content

Commit

Permalink
fix(gitignore): environment variable introduction (#364)
Browse files Browse the repository at this point in the history
## Introduction
Missing `SINGLE_LINE_LOG_FORMAT` env variable.

## Resolution
* Added `SINGLE_LINE_LOG_FORMAT`.

## Miscellaneous
* Dependencies updates
* Updated `.gitignore`

---------

Co-authored-by: Abhi Markan <abhi.markan@ukexportfinance.gov.uk>
  • Loading branch information
abhi-markan and Abhi Markan authored Jul 28, 2023
1 parent ee24d08 commit 3336d22
Show file tree
Hide file tree
Showing 6 changed files with 134 additions and 149 deletions.
12 changes: 8 additions & 4 deletions .env.sample
Original file line number Diff line number Diff line change
@@ -1,9 +1,12 @@
# PORT
PORT=
PORT=3000

# NODE
NODE_ENV=development
TZ=Europe/London 
LOG_LEVEL=debug
REDACT_LOGS=false
SINGLE_LINE_LOG_FORMAT=true
SINGLE_LINE_LOG_FORMAT=false

# Swagger
SWAGGER_USER=
Expand Down Expand Up @@ -34,12 +37,13 @@ DATABASE_CEDAR_NAME=
DATABASE_CIS_HOST=
DATABASE_CIS_NAME=

# API
API_KEY=

# INFORMATICA
APIM_INFORMATICA_URL=
APIM_INFORMATICA_USERNAME=
APIM_INFORMATICA_PASSWORD=
APIM_INFORMATICA_MAX_REDIRECTS=
APIM_INFORMATICA_TIMEOUT=

# API
API_KEY=
7 changes: 4 additions & 3 deletions .github/workflows/deployment.yml
Original file line number Diff line number Diff line change
Expand Up @@ -121,10 +121,11 @@ jobs:
--revision-suffix v${{ github.run_id }} \
--set-env-vars \
"PORT=${{ secrets.PORT }}" \
"NODE_ENV=${{ secrets.NODE_ENV }}" \
"LOG_LEVEL=${{ secrets.LOG_LEVEL }}" \
"REDACT_LOGS=${{ secrets.REDACT_LOGS }}" \
"TZ=${{ secrets.TZ }}" \
"NODE_ENV=${{ secrets.NODE_ENV }}" \
"LOG_LEVEL=${{ vars.LOG_LEVEL }}" \
"REDACT_LOGS=${{ vars.REDACT_LOGS }}" \
"SINGLE_LINE_LOG_FORMAT=${{ vars.SINGLE_LINE_LOG_FORMAT }}" \
"SWAGGER_USER=${{ secrets.SWAGGER_USER }}" \
"SWAGGER_PASSWORD=${{ secrets.SWAGGER_PASSWORD }}" \
"DATABASE_PORT=${{ secrets.DATABASE_PORT }}" \
Expand Down
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
# UKEF
.env*
.env
.env.prod

# compiled output
/dist
Expand Down
3 changes: 2 additions & 1 deletion docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,10 @@ services:
environment:
PORT:
NODE_ENV:
TZ:
LOG_LEVEL:
REDACT_LOGS:
TZ:
SINGLE_LINE_LOG_FORMAT:
SWAGGER_USER:
SWAGGER_PASSWORD:
DATABASE_PORT:
Expand Down
Loading

0 comments on commit 3336d22

Please sign in to comment.