generated from UK-Export-Finance/nestjs-template
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(FN-3664): add risk data to created customers #1163
Merged
abhi-markan
merged 7 commits into
main
from
feat/FN-3664/add-risk-data-to-created-customers
Jan 23, 2025
Merged
feat(FN-3664): add risk data to created customers #1163
abhi-markan
merged 7 commits into
main
from
feat/FN-3664/add-risk-data-to-created-customers
Jan 23, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natdeanlewissoftwire
had a problem deploying
to
qa
January 21, 2025 15:31 — with
GitHub Actions
Failure
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:31 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:31 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:31 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:31 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:45 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:45 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:45 — with
GitHub Actions
Inactive
natdeanlewissoftwire
had a problem deploying
to
qa
January 21, 2025 15:45 — with
GitHub Actions
Failure
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:45 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:57 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:57 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:57 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:57 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 21, 2025 15:57 — with
GitHub Actions
Inactive
natdeanlewissoftwire
changed the title
feat: add defaulted risk fields
feat(FN-3664): Add risk data to created customers
Jan 21, 2025
abhi-markan
requested changes
Jan 22, 2025
natdeanlewissoftwire
temporarily deployed
to
qa
January 22, 2025 15:09 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 22, 2025 15:09 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 22, 2025 15:09 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 22, 2025 15:09 — with
GitHub Actions
Inactive
natdeanlewissoftwire
had a problem deploying
to
qa
January 22, 2025 15:09 — with
GitHub Actions
Failure
natdeanlewissoftwire
changed the title
feat(FN-3664): Add risk data to created customers
feat(FN-3664): add risk data to created customers
Jan 22, 2025
natdeanlewissoftwire
had a problem deploying
to
qa
January 22, 2025 15:13 — with
GitHub Actions
Failure
natdeanlewissoftwire
had a problem deploying
to
qa
January 22, 2025 15:29 — with
GitHub Actions
Failure
natdeanlewissoftwire
temporarily deployed
to
qa
January 22, 2025 15:34 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 22, 2025 15:34 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 22, 2025 15:34 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 22, 2025 15:34 — with
GitHub Actions
Inactive
natdeanlewissoftwire
temporarily deployed
to
qa
January 22, 2025 15:34 — with
GitHub Actions
Inactive
Quality Gate passedIssues Measures |
abhi-markan
approved these changes
Jan 23, 2025
abhi-markan
deleted the
feat/FN-3664/add-risk-data-to-created-customers
branch
January 23, 2025 08:20
abhi-markan
added a commit
that referenced
this pull request
Jan 23, 2025
🤖 I have created a release *beep* *boop* --- ## [1.24.0](v1.23.0...v1.24.0) (2025-01-23) ### Features * **FN-3664:** add risk data to created customers ([#1163](#1163)) ([5ff21fa](5ff21fa)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
In discussion with Risk teams, they wanted Risk data to be added to newly created customers in Salesforce.
The APIM side will default Risk rating at B+ and Loss given default at 50%, and the DTFS side will pass Probability of Default through to APIM to be set on the new record.
Resolution ✔️
Defaults the first two risk values, and sets the Probability of Default value to the value DTFS passes through.
Miscellaneous ➕
A small doc typo fix I found.