Deploy to staging (and production) with containers #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* During Heroku deploys we can build a new container successfully, but the release phase fails with a seg fault with similar output to sass/sassc-ruby#133 * After a lot of cross referencing between this app and a recent working example of Heroku containers (https://github.com/LBHackney-IT/report-a-defect) it worked until Standard.rb was added and bumped this gem. Setting it backwards until a new version can be made fixed the issue. * Tests run, including standard. And the page is styled correctly with it's assets precompiled. There doesn't _look_ to be a negative impact of removing reverting minor update.
Along with this, we will use `heroku stack:set container` to tell Heroku to use Docker for this app
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
developmaster- this was done to help facilitate testing as production wasn't being used2.2.1. When reverting this change the release then succeeds so to fix the problem we locksasscto the minor version2.0.xuntil they have a fix in place.Currently this branch has been force pushed to master and can be reviewed at the URL to verify the assets are still compiled correctly and within Travis's build job to verify containers were deployed against the expected Git SHA:
677a310be6ca3858fa32462b23fd800026e81683.Next steps