-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redirect base URL to start page when running locally #319
Conversation
@samyou-softwire Will be because your browser is using HTTPS rather than HTTP for the base path - if you manually change it then it should remember it for next time |
ah this worked thanks, though after making the change to http://localhost:5001/ it still redirects me to https://www.gov.uk/improve-energy-efficiency on local dev |
On this branch? Not what happens for me 🤔 |
purged my docker cache and this now seems to be working 👍 |
@Glenn-Clarke would you mind giving this a try as well to make sure everything's been ironed out? |
Mine is taking me to the GDS homepage when I'm trying. |
I've consulted with Sammy, and I'm clearing my docker cache. Will update when I have results |
Mine doesn't seem to be benefiting from clearing the Docker cache like Sammy's did @jdgage |
It doesn't appear that #if DEBUG is being respected, despite debug being selected as the configuration in my rider build options |
The Dockerfile is used for deployed environments, so default to Release configuration, but the docker-compose file is only used locally
As far as I can tell Rider is doing something magic and overriding the build configuration with whatever you've got selected when you run docker compose from there (@Glenn-Clarke I expect you've got I've made it so you'll always get the Debug config when running via docker-compose (which should only be the case when running locally - it will default to Release if you build directly from the Dockerfile) and then added a comment to explain what Rider's doing. I was also getting errors due to race conditions the first time I ran @Glenn-Clarke @samyou-softwire If you wouldn't mind re-testing quickly at some point I'd appreciate it! |
I've only just got in so I'll run through the rest of it, but just to confirm quickly: I've always had Debug selected in the little dropdown next to the hammer. |
It works as expected now after your most recent commits; I get taken to the first question when I type in http://localhost:5001 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me as well
Description
Similar to how we have on WH:LG now, to get it off my to-do list
Checklist