Feat: New Pill style component #287
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: ally page * feat: updated data upload to be design system
* feat: updated content for 3 pages * doc: update readme for read more --------- Co-authored-by: Tom Barham <24593464+ecstaticrainbow@users.noreply.github.com>
github-actions
bot
added
package: core
package: angular
package: website
package: react
labels
…lty-design-system into 171-new-pill-style-component
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-287.westeurope.azurestaticapps.net |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-287.westeurope.azurestaticapps.net |
|
I know the issue shows "Do you want to leave this page?" as the example, but to me it feels like that wouldn't be the use for this component, perhaps we can use some different wording on the examples |
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://thankful-pebble-018989203-287.westeurope.azurestaticapps.net |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#171 - New pill style component
Introduces a new pill style component to the library, with 3 different variants and the ability to have icons and sub content within it.
Below shows the different styles and options available for the pill
Closed feat: Add Pill component as its a duplicate.
📦 Published PR as canary version:
3.1.1--canary.287.601f273.0✨ Test out this PR locally via:
npm install @ukho/admiralty-angular@3.1.1--canary.287.601f273.0 npm install @ukho/admiralty-core@3.1.1--canary.287.601f273.0 npm install @ukho/admiralty-react@3.1.1--canary.287.601f273.0 # or yarn add @ukho/admiralty-angular@3.1.1--canary.287.601f273.0 yarn add @ukho/admiralty-core@3.1.1--canary.287.601f273.0 yarn add @ukho/admiralty-react@3.1.1--canary.287.601f273.0