feat: Header Components - tab through navigation using keyboard #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UKHOGreg
previously requested changes
Jul 7, 2023
packages/core/src/components/header-menu-item/header-menu-item.scss
Outdated
Show resolved
Hide resolved
packages/core/src/components/header-menu-item/header-menu-item.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/header-menu-item/header-menu-item.tsx
Outdated
Show resolved
Hide resolved
packages/core/src/components/header-menu-item/header-menu-item.tsx
Outdated
Show resolved
Hide resolved
UKHOGreg
changed the title
|
Header with no title still focuses on the empty title
|
|
I think we should not render the title html if the title prop is falsey, just to avoid unnecessary tab stops |
UKHOGreg
requested review from
UKHOGreg and
ecstaticrainbow
and removed request for
UKHOGreg
|
UI review on TB's behalf |
|
🚀 PR was released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📦 Published PR as canary version:
0.3.10--canary.62.dbf76a9.0✨ Test out this PR locally via:
npm install @ukho/admiralty-angular@0.3.10--canary.62.dbf76a9.0 npm install @ukho/admiralty-core@0.3.10--canary.62.dbf76a9.0 # or yarn add @ukho/admiralty-angular@0.3.10--canary.62.dbf76a9.0 yarn add @ukho/admiralty-core@0.3.10--canary.62.dbf76a9.0