Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UI for amending ASRU access roles #48

Merged
merged 5 commits into from
Jan 11, 2019
Merged

Conversation

lennym
Copy link
Contributor

@lennym lennym commented Jan 11, 2019

No description provided.

@lennym lennym force-pushed the feature/asruify-user branch 2 times, most recently from c3a0b6f to cf273dd Compare January 11, 2019 14:13
return null;
}

const available = ['asruAdmin', 'asruLicensing', 'asruInspector'];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use this in at least 3 places, might be worth extracting?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. It's passed to the client in locals now.

When a user either does not have user admin privileges or is viewing their own profile then they should still be able to see the roles that an ASRU user has.
Pass this list to the client on `locals.static` so it can be used there without being separately defined in components.
@wheelsandcogs wheelsandcogs merged commit 0b153f1 into master Jan 11, 2019
@wheelsandcogs wheelsandcogs deleted the feature/asruify-user branch January 11, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants