Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drtii 1316 feedback #1745

Merged
merged 12 commits into from
Dec 8, 2023
Merged

Drtii 1316 feedback #1745

merged 12 commits into from
Dec 8, 2023

Conversation

ngu04
Copy link
Contributor

@ngu04 ngu04 commented Dec 4, 2023

  • Implementing Banner for feedback with AB Testing
  • Removing thumbs feedback
  • Implementing regular feedback in contact us page

richbirch
richbirch requested changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@richbirch richbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one again!
Just some tidying, and some suggestions to simplify code and ui layout (without using floats!)

client/src/main/scala/drt/client/components/ContactPage.scala Outdated Show resolved Hide resolved
client/src/main/scala/drt/client/components/ContactPage.scala Outdated Show resolved Hide resolved
client/src/main/scala/drt/client/components/Layout.scala Outdated Show resolved Hide resolved
client/src/main/scala/drt/client/components/Layout.scala Outdated Show resolved Hide resolved
client/src/main/scala/drt/client/components/Layout.scala Outdated Show resolved Hide resolved
server/src/main/scala/controllers/application/ABFeatureController.scala Outdated Show resolved Hide resolved
server/src/main/scala/controllers/application/ABFeatureController.scala Outdated Show resolved Hide resolved
server/src/main/scala/controllers/application/UserFeedbackController.scala Outdated Show resolved Hide resolved
server/src/main/scala/controllers/application/UserFeedbackController.scala Outdated Show resolved Hide resolved
DRTII-1316 review comments
c078e22 
Signed-off-by: Nilesh Gupta <nilesh.nemichandgupta@digital.homeoffice.gov.uk>
richbirch
richbirch approved these changes Dec 6, 2023
View reviewed changes
Copy link
Collaborator

@richbirch richbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top stuff!

DRTII-1316 move close banner for feedback to user from feeback table
d3abd4e 
Signed-off-by: Nilesh Gupta <nilesh.nemichandgupta@digital.homeoffice.gov.uk>
richbirch
richbirch requested changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@richbirch richbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 things:

  • I think the user should see the banner after 2 months of submitting feedback
  • add the new column to the user schema sql file

server/src/main/scala/controllers/Application.scala Outdated Show resolved Hide resolved
server/src/main/scala/slickdb/Tables.scala Show resolved Hide resolved
DRTII-1316 adding 180 days check for user feedback
dee9c10 
Signed-off-by: Nilesh Gupta <nilesh.nemichandgupta@digital.homeoffice.gov.uk>
richbirch
richbirch approved these changes Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@richbirch richbirch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Boom! 💥

@ngu04 ngu04 merged commit 6a16ecd into master Dec 8, 2023
@ngu04 ngu04 deleted the DRTII-1316-feedback branch April 5, 2024 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richbirch richbirch richbirch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngu04 @richbirch