Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drtii 1667 spike acl origin not always matching api origin #1976

Merged

Conversation

richbirch
Copy link
Collaborator

Use arrival's new previous port field to match API manifests when different to the origin
Display previous port in feeds popup for each arrival
Rename ArrivalKey to ManifestKey as that's the only thing it's used for
Remove a lot of dead code

Copy link
Contributor

@ngu04 ngu04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one !
I was just thinking—if the previous port is related to the previous origin, wouldn't previousOrigin be a better name than previousPort?

@richbirch
Copy link
Collaborator Author

Nice one ! I was just thinking—if the previous port is related to the previous origin, wouldn't previousOrigin be a better name than previousPort?

Origin is where the flight began, previous port is the last port it took off from. I guess a flight should only have one origin

@richbirch richbirch merged commit a0fd720 into master Jan 9, 2025
2 checks passed
@richbirch richbirch deleted the DRTII-1667-SPIKE-ACL-origin-not-always-matching-API-origin branch January 9, 2025 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants