Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP HOFF-926 filevault upgrade #516

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sulthan-ahmed
Copy link
Contributor

@sulthan-ahmed sulthan-ahmed commented Nov 7, 2024

This is in relation PR HOFF-403: Fix security vulnerabilities in file-vault
UKHomeOffice/file-vault@8e8c781 This is only for testing purposes in the branch

What?

This is to upgrade filevault
https://collaboration.homeoffice.gov.uk/jira/browse/HOFF-926
It's not to be merged in as the file-vault version used is in a branch itself

Why?

There are security vulnerabilities in the older version of file-vault

How?

Testing?

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

This is in relation PR HOFF-403: Fix security vulnerabilities in
file-vault
UKHomeOffice/file-vault@8e8c781
This is only for testing purposes in the branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant