Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HOFF-657: Update GRO to version of hof using axios #312

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

HOFF-657: Update GRO to version of hof using axios #312

wants to merge 1 commit into from

Conversation

Rhodine-orleans-lindsay
Copy link

@Rhodine-orleans-lindsay Rhodine-orleans-lindsay commented Apr 4, 2024 •
edited
Loading

What

  • Update gro to use version of hof which replaces request module with axios - HOFF-657

Why

  • The request module in hof is deprecated and has vulnerabilities so has been replaced by axios.

How

  • update hof version to use axios
  • update yarn.lock

Testing

  • tests passing locally

Screenshots(optional)

Anything else(optional)

@Rhodine-orleans-lindsay Rhodine-orleans-lindsay marked this pull request as draft April 4, 2024 15:40
@Rhodine-orleans-lindsay Rhodine-orleans-lindsay force-pushed the HOFF-657-update-hof-version-to-use-axios branch from 9d7a683 to ef49459 Compare April 4, 2024 16:05
@Rhodine-orleans-lindsay Rhodine-orleans-lindsay force-pushed the HOFF-657-update-hof-version-to-use-axios branch from ef49459 to 6fccaf0 Compare July 18, 2024 18:52
@Rhodine-orleans-lindsay Rhodine-orleans-lindsay requested review from sulthan-ahmed and removed request for TemitopeAyokuHO July 18, 2024 20:16
@Rhodine-orleans-lindsay Rhodine-orleans-lindsay force-pushed the HOFF-657-update-hof-version-to-use-axios branch from 6fccaf0 to 6b36281 Compare July 22, 2024 11:49
@Rhodine-orleans-lindsay Rhodine-orleans-lindsay marked this pull request as ready for review July 22, 2024 11:52
sulthan-ahmed
sulthan-ahmed approved these changes Aug 5, 2024
View reviewed changes
Copy link
Contributor

@sulthan-ahmed sulthan-ahmed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@Rhodine-orleans-lindsay
HOFF-657: Update GRO to version of hof using axios
5c95560 
- update hof version package.json
- update yarn.lock
@Rhodine-orleans-lindsay Rhodine-orleans-lindsay force-pushed the HOFF-657-update-hof-version-to-use-axios branch from 6b36281 to 5c95560 Compare October 1, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sulthan-ahmed sulthan-ahmed sulthan-ahmed approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rhodine-orleans-lindsay @sulthan-ahmed