Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROD-58 Type of visa application page #12

Merged
merged 7 commits into from
Oct 8, 2024

Conversation

vivekkumar-ho
Copy link
Contributor

@vivekkumar-ho vivekkumar-ho commented Oct 2, 2024

What?

ROD-58 - Create page for type of visa application

Why?

How?

Testing?

Tested locally

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

@vivekkumar-ho vivekkumar-ho changed the title ROD-58 type of visa application page ROD-58 Type of visa application page Oct 2, 2024
# Conflicts:
#	apps/cancel-request/fields/index.js
#	apps/cancel-request/translations/src/en/fields.json
#	apps/cancel-request/translations/src/en/validation.json
Copy link
Contributor

@RobertMcCann RobertMcCann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

# Conflicts:
#	apps/cancel-request/translations/src/en/fields.json
#	apps/cancel-request/translations/src/en/validation.json
#	assets/scss/app.scss
@vivekkumar-ho vivekkumar-ho merged commit a47d3de into master Oct 8, 2024
2 checks passed
@vivekkumar-ho vivekkumar-ho deleted the ROD-58-visa-application-type-page branch October 11, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants