Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROD-33-main application page #7

Merged
merged 4 commits into from
Oct 8, 2024
Merged

ROD-33-main application page #7

merged 4 commits into from
Oct 8, 2024

Conversation

RobertMcCann
Copy link
Contributor

What?

Why?

How?

Testing?

Screenshots (optional)

Anything Else? (optional)

Check list

  • I have reviewed my own pull request for linting issues (e.g. adding new lines)
  • I have written tests (if relevant)
  • I have created a JIRA number for my branch
  • I have created a JIRA number for my commit
  • I have followed the chris beams method for my commit https://cbea.ms/git-commit/
    here is an example commit
  • Ensure drone builds are green especially tests
  • I will squash the commits before merging

Copy link
Contributor

@vinodhasamiyappanHO vinodhasamiyappanHO left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

{
"dnr-full-name": {
"required": "Enter the main applicant's full name",
"minlength": "Applicant's full name must be 3 and 250 characters",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the word 'between' for min & maxlength

Change "Applicant's full name must be 3 and 250 characters" to

"Applicant's full name must be between 3 and 250 characters",

I spoke to UCD about this.

Copy link
Contributor

@MikeMaratheftis MikeMaratheftis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@RobertMcCann RobertMcCann merged commit 37a69be into master Oct 8, 2024
2 checks passed
@RobertMcCann RobertMcCann deleted the ROD-33-main-app branch October 8, 2024 14:24
@RobertMcCann RobertMcCann changed the title ROD-33-main application page & testing custom validation for dob ROD-33-main application page Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants