-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROD-33-main application page #7
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
{ | ||
"dnr-full-name": { | ||
"required": "Enter the main applicant's full name", | ||
"minlength": "Applicant's full name must be 3 and 250 characters", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the word 'between' for min & maxlength
Change "Applicant's full name must be 3 and 250 characters" to
"Applicant's full name must be between 3 and 250 characters",
I spoke to UCD about this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
What?
Why?
How?
Testing?
Screenshots (optional)
Anything Else? (optional)
Check list
here is an example commit