HfAPi().create_repo positional arguments to keyword arguments
#1732
Conversation
There was a problem hiding this comment.
Hi @fgbelidji , thanks for taking care of this. I've added a comment to also remove the deprecated argument organization.
(note: I am one of the maintainers of huggingface_hub. I really do not mind been tagged on PRs related to it so do not hesitate to do so if you want :) )
| token, | ||
| repo_name, | ||
| token=token, | ||
| repo_id=repo_name, |
There was a problem hiding this comment.
The organization parameter is deprecated and will soon be removed in next release of huggingface_hub (a Warning message should already be printed since version 0.8).
Suggested change is to add organization to the repo id and remove it from the arguments passed to create_repo.
| repo_id=repo_name, | |
| repo_id=f"{organization}/{repo_name}", |
There was a problem hiding this comment.
Organization might be None though and that would lead to an error I think.
Maybe we should go ahead with #1743 ?
There was a problem hiding this comment.
Yes sorry, my bad. Checking this would be better :)
Related issue #1724