[BC
] Introduce decorator hack to preserve BC with incorrect usage of save_to_hub
#2380
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #2376
Hello!
Pull Request overview
save_to_hub
Details
By incorrect usage I am referring to providing keyword arguments using positional arguments & vice versa. Through this new decorator, you can once again do:
and
I've added tests to ensure that the behaviour is indeed the same as before.
Note
This decorator hack can only be applied once, if another keyword argument is also introduced in a future version, then we can't allow positional arguments to be used with keyword arguments anymore.
cc: @osanseviero