Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating to evaluation_strategy #2686

Merged
merged 1 commit into from
May 28, 2024
Merged

updating to evaluation_strategy #2686

merged 1 commit into from
May 28, 2024

Conversation

higorsilvaa
Copy link
Contributor

There were an eval_strategy parameter that does not exist.

@higorsilvaa
updating to evaluation_strategy
bdff7a5 
There were an eval_strategy parameter that does not exist.
@tomaarsen
Copy link
Collaborator

Hello!

eval_strategy was introduced in transformers v4.41.0 from last month, but evaluation_strategy should work for older versions too (it'll just give a deprecationwarning for newer versions), so I'm happy to accept this PR once the tests go green. Thanks!

  • Tom Aarsen

@tomaarsen tomaarsen merged commit 428a994 into UKPLab:master May 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@higorsilvaa @tomaarsen