Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[simplify] Set can_return_loss=True globally, instead of via the data collator #2727

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

tomaarsen
Copy link
Collaborator

Hello!

Pull Request overview

  • Set can_return_loss=True globally instead of via the data collator
  • Also override the typings for args and data_collator for easier intellisense etc.

Details

The global can_return_loss should always be used unless the data has a return_loss sample, which we specifically forbid via validate_column_names. Sentence Transformer models can always return a loss during training, so this helps simplify our code somewhat.

  • Tom Aarsen

@tomaarsen tomaarsen merged commit 8ded768 into UKPLab:master Jun 7, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant