[simplify
] Set can_return_loss=True globally, instead of via the data collator
#2727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
Pull Request overview
args
anddata_collator
for easier intellisense etc.Details
The global
can_return_loss
should always be used unless the data has areturn_loss
sample, which we specifically forbid viavalidate_column_names
. Sentence Transformer models can always return a loss during training, so this helps simplify our code somewhat.