Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] Fix semantic_search_usearch with 'binary' #2989

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

tomaarsen
Copy link
Collaborator

Resolves #2988

Hello!

Pull Request overview

  • b1 dtype needs * 8 and ubinary data
  • i8 dtype needs binary data
  • Add trust_remote_code=True to load_dataset for Quora, required for datasets>2

Details

I think ubinary and binary have pretty similar performance (at least, with just 100k embeddings). Either way, it should work again. Thanks for reporting this @beviah

  • Tom Aarsen

@tomaarsen tomaarsen merged commit 1802076 into UKPLab:master Oct 17, 2024
11 checks passed
@tomaarsen tomaarsen deleted the fix/semantic_search_usearch branch October 17, 2024 10:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

semantic usearch example does not work
1 participant