-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Added model2vec import compatible with current and newer version #2992
Conversation
Hello! This looks solid I think! Also, torch-less inference on Have you tested sentence-transformers/sentence_transformers/models/StaticEmbedding.py Lines 202 to 203 in 1802076
|
I added some simple tests to make sure that things don't break in the future. |
@tomaarsen good catch, those need to be converted! Will update the code |
@Pringled I already have a fix locally, I'll take care of it :) |
Nice! That should work with both the old and new versions 💪 |
Hi!
Pull Request overview
Details
Starting from model2vec version 0.3, inference and distillation will be split up since inference will only need Numpy. This makes it much faster to initialize and install, since there is no dependency on Torch anymore for inference. This PR makes sentence-transformers compatible with both the old and new version, including an updated ImportError message for from_disillation.
Relevant Model2Vec commit: MinishLab/model2vec@010a7b7