Fix cache_dir issue with loading CLIPModel #3007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Already fixed in master by other means. |
|
Hello! As you already noticed, 3.2.0 works fine for e.g. https://huggingface.co/sentence-transformers/clip-ViT-L-14, but the issue does still persist if the CLIP model is saved in the root of the repository/directory. The removal of the try-except was a mistake from when I was debugging #2712, and so we should still re-introduce the try-except. This will fix the issue from #3005 (comment), although we still won't have ONNX exporting for CLIP models (yet). Thanks for opening your issue & PR. I'll include this in a quick patch very soon.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially revert this commit to fix #3005 .