Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "Comments" section to STYLE.md, referencing Natspec #1369

Merged
merged 43 commits into from
May 5, 2020
Merged

Add "Comments" section to STYLE.md, referencing Natspec #1369

merged 43 commits into from
May 5, 2020

Conversation

nicholaspai
Copy link
Member

No description provided.

nicholaspai and others added 30 commits April 28, 2020 08:40
@nicholaspai
replace transfer with requestTransfer/cancelTransfer/transferPassedRe…
12ae7bf 
…quest and updated tests

Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add requestTransferPassTimestamp to PositionData struct
f1cf668 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
enforce check-effects-interaction pattern throughout NFCT
ae729fa 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
merge master
56b4ca8 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
fix tests
141d88a 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
Merge branch 'master' into npai/nfct-reentrancy-guard
5adc740
@nicholaspai
add Reentrancy guard to FeePayer, currently out of bytecode size
ff42ea5 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@chrismaree
Fixed gas limit
68598cd 
Signed-off-by: Christopher Maree <christopher.maree@gmail.com>
@chrismaree
fixed branch
9a3344d 
Signed-off-by: Christopher Maree <christopher.maree@gmail.com>
@nicholaspai
add ReentrancyGuard to all NFCT contracts
aa24554 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
increase gas in dapp-test ci
c7d2100 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
extend ReentrancyGuard and add viewLock method
b76a9ff 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
rename local ReentryGuard, add TODO's
8347a75 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
remove nonReentrant from internal method
32f60e8 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
make EMPCreator Lockable
2f3f5f4 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
merge master
c478dd1 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add nonReentrant to all state-modifying public methods but no constru…
50143fa 
…ctors, has 94 bytes of bytecode left

Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add view-only lock to all public view methods
a7567e2 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
revert pfc() in Liquidatable
e4532f5 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
update comment
8b34b5b 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
fix comments
00321a6 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add comment about pfc
8509bcc 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
Merge branch 'master' into npai/nfct-reentrancy-guard
796001d
@nicholaspai
add unit tests for Lockable.sol
b168e94 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add credits
207e9cb 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add address(this).callViewFunction tests
856dd44 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
slither ignore
e992961 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
fix typo in Lockable, move nonReentrant to EMP from FeePayer
61bef03 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add nonReentrantView to public pfc() methods
9ad2009 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
fix local variable shadowing
acf1b3b 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
nicholaspai added 10 commits May 5, 2020 08:30
@nicholaspai
add nonReentrancy to all constructors
6c635d8 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add require messages
00dafe1 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add require messages after merge with master
9026624 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
merge master
5552bf1 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
make sure nonReentrant modifier is last
126fc0d 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
merge master
696f4a0 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
Merge branch 'master' into npai/nfct-reentrancy-guard
c8e84ef
@nicholaspai
move pfc() public method to feepayer
996e773 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
rename pfc to collateralPool to avoid local variable shadowing
55bdb2e 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai
add comment section to style.md
9025efb 
Signed-off-by: Nick Pai <npai.nyc@gmail.com>
@nicholaspai

This comment has been minimized.

Sign in to view
mrice32
mrice32 approved these changes May 5, 2020
View reviewed changes
Copy link
Member

@mrice32 mrice32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicholaspai nicholaspai merged commit b23528f into master May 5, 2020
@nicholaspai nicholaspai deleted the npai/style-guide-natspec branch May 5, 2020 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrice32 mrice32 mrice32 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholaspai @mrice32 @chrismaree