-
Notifications
You must be signed in to change notification settings - Fork 184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve(sdk): add support for Multicall2 contract #3325
improve(sdk): add support for Multicall2 contract #3325
Conversation
This pull request has been linked to Clubhouse Story #2128: add multicall 2 support to multicall sdk library. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sorry for the misunderstanding this morning, but yea i think it makes a lot of sense to separate m1 and m2 into separate folders. In my mind i had tasked this thinking you should also update the helper multicall class in lib which is what i was thinking of, but we can do that as a separate task.
anyways for the most part this looks good, but imo id say refactor it into separate clients. lmk what you think
95ee409
to
f2ce3f0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great, just one comment on the new test
09152b1
to
f922f2a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great first PR, I did one pass and mainly left comments to add more comments to the smart contracts. On second pass after you re-request my review, I'll examine the sdk
code more closely
Signed-off-by: amateima <amatei@umaproject.org>
Signed-off-by: amateima <amatei@umaproject.org>
Signed-off-by: amateima <amatei@umaproject.org>
Signed-off-by: amateima <amatei@umaproject.org>
f922f2a
to
ec61c0c
Compare
Signed-off-by: amateima <amatei@umaproject.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks awesome! This is really really nice code, and very consistent with the surrounding code and style of the repo. Very nice work @amateima!!
Just added a few minor nits and comments.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, going to approve assuming you will address rest of comments! Try to get a second approval before merging and you should be good to go
Signed-off-by: amateima <amatei@umaproject.org>
Signed-off-by: amateima <amatei@umaproject.org>
Signed-off-by: amateima <amatei@umaproject.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Motivation
https://app.clubhouse.io/uma-project/story/2128/add-multicall-2-support-to-multicall-sdk-library
Summary
Testing
Check a box to describe how you tested these changes and list the steps for reviewers to test.