Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve(logger): Update @google-cloud/logging-winston dependency #4779

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

improve(logger): Update @google-cloud/logging-winston dependency #4779

wants to merge 2 commits into from

Conversation

nicholaspai
Copy link
Member

@nicholaspai nicholaspai commented Aug 15, 2024 •
edited
Loading

Motivation

This has an upstream dependency on protobufjs@6.11.3 which has a vulnerability and is likely to cause any downstream clients issues if they run any package dependency checks on this package.

Summary

Update the @google-cloud/logging-winston to the latest version

james-a-morris
james-a-morris approved these changes Aug 15, 2024
View reviewed changes
Copy link
Contributor

@james-a-morris james-a-morris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - will recommend we get a signoff from someone closer to this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-a-morris james-a-morris james-a-morris approved these changes

@daywiss daywiss daywiss approved these changes

@mrice32 mrice32 Awaiting requested review from mrice32 mrice32 is a code owner

@chrismaree chrismaree Awaiting requested review from chrismaree chrismaree is a code owner

@md0x md0x Awaiting requested review from md0x md0x is a code owner

@Reinis-FRP Reinis-FRP Awaiting requested review from Reinis-FRP Reinis-FRP is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nicholaspai @daywiss @james-a-morris