Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cmake #123

Merged
merged 9 commits into from
Oct 27, 2021
Merged

Add cmake #123

merged 9 commits into from
Oct 27, 2021

Conversation

sanAkel
Copy link
Collaborator

@sanAkel sanAkel commented Oct 26, 2021

This PR includes following:

  1. src/obs/obsop_sst.f90: DIMENSIONS (nlon, nlat) have been replaced with ALLOCATABLE
  2. Added capability to be able to build with cmake.

Thanks to @mathomp4 for his help with ⤴️ .

All above were tested and built successfully on NASA NCCS discover cluster with:

  • cmake/3.21.0
  • comp/intel/2021.2.0
  • comp/gcc/10.1.0

sanAkel added 9 commits October 22, 2021 12:37
…r, best and EASIEST to have a single CMakeLists.txt- it is not too long since we do not have a lengthy src code listsing
…ators - except SST, obs/obsop_sst.f90 needs to be _fixed_ for DIMENSION(nlon,nlat) - later, so not building it for now.
…rs - later. In any case note that dynamic or static, dimensions: nlat, nlon, nlev are the SAME! Handgle later. For now, just build with cmake.
…d to their _original_ versions with #ifdef blocks.
@sanAkel sanAkel requested a review from StevePny October 26, 2021 23:47
@sanAkel sanAkel self-assigned this Oct 26, 2021
Copy link
Member

@StevePny StevePny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks safe.

@StevePny StevePny merged commit 26b1e8b into master Oct 27, 2021
@sanAkel sanAkel deleted the feature/sanAkel/extras branch October 27, 2021 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants