Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

need to be able to update gold on a running instance #45

Open
pahp opened this issue Sep 25, 2019 · 3 comments
Open

need to be able to update gold on a running instance #45

pahp opened this issue Sep 25, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@pahp
Copy link
Contributor

pahp commented Sep 25, 2019

Attacks often find true bugs in the gold program. We need to be able to update the gold program of a running instance. I propose that the admin should be able to push to a repo where gold lives and it is rebuilt and cached upon a change. Players always find bugs in gold.

@pahp pahp added the bug Something isn't working label Sep 25, 2019
@ChandlerSwift
Copy link
Member

ChandlerSwift commented Oct 11, 2019

When we fix this, we'll have to make sure that we remove any cached Docker instance as well, or force a rebuild of it. Currently we cache the gold image, and that would cause problems if we ever wanted to update it during a competition.

@ChandlerSwift
Copy link
Member

Removing the docker image after updating the code in /pack/gold is sufficient to trigger a rebuild. docker image rm gold (possibly after docker container prune to remove all containers that might depend on it) removes the gold image, and forces a rebuild.

In theory, it would be nice to be able to do this more automatically. @pahp, discussion on what this looks like?

@ChandlerSwift
Copy link
Member

Also, it would not be terribly difficult to add a button to the admin UI to perform this docker image rm step, though it removes one layer of separation between the web UI and the docker control plane that is nice to have for security-in-depth, as it would require us to let the web container be able to control Docker.

ChandlerSwift added a commit that referenced this issue Jul 23, 2020
This fix #38, fixes one issue seen in #95, and paves the way for #45.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants