Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ignore audit warning that doesn't affect us #144

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

lazysoundsystem
Copy link
Contributor

Refs: OPS-10899

@lazysoundsystem
Copy link
Contributor Author

If this is okay, @cafuego, I have similar PRs for all the other repos, which probably don't need individual reviews as they're all the same change.

(Note that some, like UN-OCHA/common-design-site#484, add the "abandoned": "report", directive for consistency. If that's not useful, I can remove those.)

Copy link

Coverage Report

Totals Coverage

Copy link

Build output

Composer Validate success

PHP Lint success

Docker Build success

Environment Setup success

Site Install success

PHP Code Sniffer success

Software Versions PHP 8.2.23 (cli) (built: Aug 31 2024 04:38:56) (NTS) Copyright (c) The PHP Group Zend Engine v4.2.23, Copyright (c) Zend Technologies with Zend OPcache v8.2.23, Copyright (c), by Zend Technologies with Xdebug v3.3.2, Copyright (c) 2002-2024, by Derick Rethans Composer version 2.7.9 2024-09-04 14:43:28
Drupal Logs
PHP Logs

Pusher: @lazysoundsystem, Action: pull_request, Workflow: Run tests

Copy link
Contributor

@cafuego cafuego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. Generally speaking, abandoned apckages end up being dependencies from Drupal contrib modules, so they need upstream fixes. A warning here seems more reasonable than a test fail.

@lazysoundsystem lazysoundsystem merged commit 0aff09e into develop Sep 26, 2024
2 checks passed
@lazysoundsystem lazysoundsystem deleted the OPS-10899-audit-ignore branch September 26, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants