Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use light/dark favicons #497

Merged
merged 2 commits into from
Dec 20, 2024
Merged

feat: Use light/dark favicons #497

merged 2 commits into from
Dec 20, 2024

Conversation

attiks
Copy link
Contributor

@attiks attiks commented Dec 18, 2024

Refs: #OPS-11179

Types of changes

  • ✔️ Add support for light/dark favicon

Description

New option to enable support for light/dark favicons, disabled by default.

Code checks active theme and parent themes.

PR Checklist

  • I have followed the Conventional Commits guidelines.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have made changes to the sub theme to reflect those in the base theme

@attiks attiks requested a review from orakili December 18, 2024 11:14
orakili
orakili approved these changes Dec 19, 2024
View reviewed changes
Copy link
Contributor

@orakili orakili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, but maybe better to check for the existence of the white icon as well?

@attiks attiks requested a review from orakili December 19, 2024 11:50
@attiks attiks merged commit a10bc38 into develop Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orakili orakili orakili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@attiks @orakili