HPC-9238: Upgrade to Node.js v20 #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pl217
added
ready for review
Pl217
changed the title
Pl217
added
the
pending prior merge
Node.js v18.18.2 has multiple security fixes, so we don't want earlier versions
We still keep v18 as a valid option, since Dependabot runner image still uses it https://github.com/dependabot/dependabot-core/blob/main/npm_and_yarn/Dockerfile
This commit is the output of running `yarn prettier --write --single-quote --trailing-comma es5 .`
Since ESLint and Typescript are peer dependencies, we need to update them too
This commit is the output of command: `yarn prettier --write .` Prettier plugin uses same feature that VS Code's "Organize import" uses to order the imports
This is done to prepare for flat ESLint config which will be rolled out in v9 https://eslint.org/blog/2023/10/flat-config-rollout-plans
Upon release of v6 of `@typescript-eslint/*` packages, `no-explicit-any` started throwing errors, which is a good default behavior, but not something we're ready to embrace due to lots of `any` usages in generic code typescript-eslint/typescript-eslint#7130
This commit is the output of running ``` yarn eslint --quiet --fix . yarn prettier -w $(git diff --staged --name-only) ```
Manually fixed following linting errors: * @typescript-eslint/prefer-nullish-coalescing * unicorn/consistent-destructuring After this commit, output of `yarn eslint --quiet --fix .` should be clean
Utilize `ignoreRevsFile` of `git blame` to ignore revisions in which major formatting and linting changes happened to the codebase, which polluted the contribution history.
Delgee
approved these changes
Nov 2, 2023
Delgee
removed
ready for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs UN-OCHA/hpc-repo-tools#31 merged+released first