HPC-8569 get table columns function

[manelcecs]

No description provided.

[Delgee]

Since getTableColumns is runtime version of

hpc-api-core/src/db/util/model-definition.ts

Line 74 in dc5888a

export type InstanceDataOf<F extends FieldDefinition> = FieldValuesOfSet<

can we do it similar fashion instead of looping through every child.

[manelcecs]

Since getTableColumns is runtime version of

hpc-api-core/src/db/util/model-definition.ts

Line 74 in dc5888a

export type InstanceDataOf<F extends FieldDefinition> = FieldValuesOfSet<

can we do it similar fashion instead of looping through every child.

Would this code be a better approach?

export const getTableColumns = <
  T extends { _internals: { fields: FieldDefinition } },
>(
  table: T
): string[] => {
  const {
    generated,
    generatedCompositeKey,
    nonNullWithDefault,
    required,
    optional,
    accidentallyOptional,
  } = table._internals.fields;

  // Collect columns from all subsets
  const columns = [
    ...Object.keys(generated ?? {}),
    ...Object.keys(generatedCompositeKey ?? {}),
    ...Object.keys(nonNullWithDefault ?? {}),
    ...Object.keys(required ?? {}),
    ...Object.keys(optional ?? {}),
    ...Object.keys(accidentallyOptional ?? {}),
  ];

  return columns;
};

[Delgee]

I believe so.